Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: indexing on segments #117

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat: indexing on segments #117

merged 3 commits into from
Nov 8, 2023

Conversation

usamoi
Copy link
Collaborator

@usamoi usamoi commented Nov 8, 2023 •
edited

This PR temporarily removes vamana.

Closes , #69, #77, #96, #97.

@usamoi
feat: indexing on segments
03191e4 
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi
Copy link
Collaborator Author

usamoi commented Nov 8, 2023

r? @VoVAllen

@usamoi usamoi requested a review from VoVAllen November 8, 2023 13:23
VoVAllen
VoVAllen reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is there any benchmark numbers?

src/algorithms/impls/vamana.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
VoVAllen
VoVAllen reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add some tests for

  • the configurations added (segment options),
  • the configurations for the quantization options
  • the case for the issue fixed

README.md Show resolved Hide resolved
@usamoi
fix: add vamana back
85a5646 
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi
test: update tests for error message
d2ba1b1 
Signed-off-by: usamoi <usamoi@outlook.com>
VoVAllen
VoVAllen approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for your effort!

@VoVAllen VoVAllen added this pull request to the merge queue Nov 8, 2023
Merged via the queue into tensorchord:main with commit 4bc6e11 Nov 8, 2023
4 checks passed
This was referenced Nov 9, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@usamoi @VoVAllen