Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guideline for moving from tf.contrib #45

Closed
seanpmorgan opened this issue Feb 21, 2019 · 3 comments
Closed

Add contribution guideline for moving from tf.contrib #45

seanpmorgan opened this issue Feb 21, 2019 · 3 comments
Assignees
Labels
documentation help wanted Needs help as a contribution

Comments

@seanpmorgan
Copy link
Member

seanpmorgan commented Feb 21, 2019

@dynamicwebpaige wisely suggested in #38 that we put together a guideline on moving from tf.contrib to addons. A majority of our code is currently ported from tf.contrib and there are many open issues for bringing over the rest of our addons RFC.

Some things to include in the guideline:

  • TF2.0 symbols mapping
  • Guidelines on when to use tf.function
  • Common code changes (remove variable_scope, etc.)
  • Suggestions on adding aditional test cases

I imagine we would hold this document in the repo for a substantial amount of time, but ultimately will want to remove it as we grow away from our original codebase of ported tf.contrib code

@seanpmorgan seanpmorgan added help wanted Needs help as a contribution documentation labels Feb 21, 2019
@dynamicwebpaige dynamicwebpaige self-assigned this Feb 21, 2019
@dynamicwebpaige
Copy link
Contributor

cc: @karmel for visibility.

@dynamicwebpaige dynamicwebpaige added this to In progress in TensorFlow 2.0 Apr 17, 2019
@dynamicwebpaige
Copy link
Contributor

Currently being worked by two Google Summer of Code students: Vishal and Adrian.

@seanpmorgan
Copy link
Member Author

Closing as we're more or less past moving code from tf.contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation help wanted Needs help as a contribution
Projects
TensorFlow 2.0
  
In progress
Development

No branches or pull requests

2 participants