Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution docs #38

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Conversation

seanpmorgan
Copy link
Member

Major doc changes...

  • Added project core concepts to central README
  • Added table of contents to central README
  • Began separate contribution guidelines for each sub-package API

Just a note.. there is a planned PR coming which will place all "custom op" sub-packages under a single API type so that we can have contribution guidelines similar to layers, losses, and optimizers.

@seanpmorgan seanpmorgan changed the title 23 contribution docs Contribution docs Feb 18, 2019
Copy link
Contributor

@armando-fandango armando-fandango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !!!

Copy link
Member

@facaiy facaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :-)

tensorflow_addons/losses/README.md Show resolved Hide resolved
# Scope
The tensorflow/addons repository, will contain additional functionality fitting the following criteria:
## Contents
| Sub-Package | Addon | Reference |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table seems redundant, and also might become a too long list to maintain in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is not sustainable in the long term. I would like a single list of whats available so new users can quickly see if what they need is available, without having to dig through the repo. Are you okay with keeping this until we have setup our Python API docs to show package contents.

For example: https://pytorch.org/docs/master/torchvision/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Great, that's what I think. We can remove it after API docs is set up in the future.

@karmel
Copy link
Contributor

karmel commented Feb 19, 2019

@dynamicwebpaige -- it would be great to have your review here given your work on this for TF.

@dynamicwebpaige
Copy link
Contributor

😄 This is a great start! I'd also like to see sections on:

  • Governance and support (ex: the addons repo will periodically run CI tests and if package fails to meet criteria for x time period, it will be deprecated).

  • Proxy maintainership (responsibilities and expectations).

  • Preferred methods of communication (ex: the Gitter channel, mailing list, SIG Addons meeting).

  • A link to the 1:1 symbols map (though ideally a markdown version).

  • How users can file requests for packages to migrate.

  • A link to the tf.contrib analyzer for ideas on which packages would be useful to target next.

Does that make sense? I'm not sure if this would fit here, or elsewhere in Addons. Am also happy to share a copy of the contribution guide we've been working on internally for TensorFlow.

@seanpmorgan
Copy link
Member Author

Thanks so much for the review @dynamicwebpaige

  1. Great idea, at the upcoming meeting I'd like to discuss an RFC so we can clarify with the community our method of deprecating / removing.

  2. Proxy maintainership I'd also like to be tied into that RFC. For example if there is no proxy maintainer that will have implications on the removal

  3. I'm planning on adding an image to the gitter channel after our nightly CI is set and it can be included in those images. Example here

  4. I'm open to the idea of having that somewhere in the repo for a temporary amount of time. I think this repo has a vested interest in becoming an independent repo not a guide on TF2.0 conversion.

  5. Great idea. I've created an issue to create a template for issue submissions.

  6. Also open to this idea for a temporary time. I also think this repository has an interest in becoming more than the new location of tf.contrib. I'm also concerned about the last update to that page being ~Nov 2018. Do we know if we can ask for an updated pull?

@seanpmorgan
Copy link
Member Author

Merging this as its blocking a new repository structure I'd like to submit. Still entirely open to discussing the comments though and I think the repo plans on many more iterations of our documentation.

@seanpmorgan seanpmorgan merged commit e07449a into tensorflow:master Feb 21, 2019
@seanpmorgan seanpmorgan deleted the 23-contribution-docs branch February 21, 2019 02:32
@seanpmorgan
Copy link
Member Author

Also would love to tie in those new contribution guidelines @dynamicwebpaige

Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
* ENH: Update contribution and project docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants