-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution docs #38
Contribution docs #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work :-)
# Scope | ||
The tensorflow/addons repository, will contain additional functionality fitting the following criteria: | ||
## Contents | ||
| Sub-Package | Addon | Reference | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table seems redundant, and also might become a too long list to maintain in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is not sustainable in the long term. I would like a single list of whats available so new users can quickly see if what they need is available, without having to dig through the repo. Are you okay with keeping this until we have setup our Python API docs to show package contents.
For example: https://pytorch.org/docs/master/torchvision/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Great, that's what I think. We can remove it after API docs is set up in the future.
@dynamicwebpaige -- it would be great to have your review here given your work on this for TF. |
😄 This is a great start! I'd also like to see sections on:
Does that make sense? I'm not sure if this would fit here, or elsewhere in Addons. Am also happy to share a copy of the contribution guide we've been working on internally for TensorFlow. |
Thanks so much for the review @dynamicwebpaige
|
Merging this as its blocking a new repository structure I'd like to submit. Still entirely open to discussing the comments though and I think the repo plans on many more iterations of our documentation. |
Also would love to tie in those new contribution guidelines @dynamicwebpaige |
* ENH: Update contribution and project docs
Major doc changes...
Just a note.. there is a planned PR coming which will place all "custom op" sub-packages under a single API type so that we can have contribution guidelines similar to
layers
,losses
, andoptimizers
.