Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PolynomialCrossing to Addons #1018

Merged
merged 8 commits into from Feb 4, 2020
Merged

Add PolynomialCrossing to Addons #1018

merged 8 commits into from Feb 4, 2020

Conversation

tanzhenyu
Copy link
Contributor

This is from internal design to open-source the DCN network from paper https://arxiv.org/abs/1708.05123

@tanzhenyu
Add PolynomialCrossing to Addons
18e3edb 
This is from internal design to open-source the DCN network from paper https://arxiv.org/abs/1708.05123
@boring-cyborg boring-cyborg bot added the layers label Feb 3, 2020
@tanzhenyu
Add PolynomialCrossing to Addonds 2
5dbe61c 
Update commit per Addons format.
@seanpmorgan
Copy link
Member

Majority of issues seem to stem from formatting. Could you please run black ./ or bash tools/run_docker.sh -c 'make code-format'

@tanzhenyu
more indentation fix
806cadf 
More indentitation fix.
@tanzhenyu
Copy link
Contributor Author

Majority of issues seem to stem from formatting. Could you please run black ./ or bash tools/run_docker.sh -c 'make code-format'

Done.

seanpmorgan
seanpmorgan requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more test cases and then LGTM. Thanks for the nice PR!

tensorflow_addons/layers/polynomial_test.py Outdated Show resolved Hide resolved
tensorflow_addons/layers/polynomial.py Show resolved Hide resolved
tensorflow_addons/layers/polynomial.py Show resolved Hide resolved
@tanzhenyu
Copy link
Contributor Author

@seanpmorgan Thanks Sean for the review! Any idea on what the sanity check is doing?
error message - "the remote end hung up unexpectedly; early EOF; index-pack failed; Git fetch failed with exit code: 128"
https://github.com/tensorflow/addons/pull/1018/checks?check_run_id=424954024

@gabrieldemarmiesse
Copy link
Member

I think it's just a connection issue. I'll restart the tests.

@tanzhenyu
Copy link
Contributor Author

I think it's just a connection issue. I'll restart the tests.

Thanks!

seanpmorgan
seanpmorgan approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR!

@seanpmorgan seanpmorgan merged commit 3337e98 into tensorflow:master Feb 4, 2020
@tanzhenyu
Copy link
Contributor Author

LGTM thanks for the PR!

Thanks for the review!

@tanzhenyu tanzhenyu deleted the crossing branch February 4, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@facaiy facaiy Awaiting requested review from facaiy

Assignees
No one assigned
Labels
cla: yes layers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanzhenyu @seanpmorgan @gabrieldemarmiesse @googlebot