Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup sharpness #1836

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented May 15, 2020

tf.nn.depthwise_conv2d can work on 4D image directly so we do not need to use tf.map_fn to operate image-by-image. Achieve about 1.5X speed on large batch of images.
https://colab.research.google.com/drive/1yqqBp6-aXXgUbmN-c-DMOl0RgSaRYX4j?usp=sharing

@bot-of-gabrieldemarmiesse

@abhichou4

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@bhack
Copy link
Contributor

bhack commented May 15, 2020

we do not need to use tf.map_fn

For the general knowledge the original issue releted tf.map_fn is going to be solved merging tensorflow/tensorflow#39541

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tyvm!

@seanpmorgan seanpmorgan merged commit ecf2311 into tensorflow:master May 15, 2020
ashutosh1919 pushed a commit to ashutosh1919/addons that referenced this pull request Jul 12, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants