New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the so loading in dev mode #1909
Conversation
@@ -34,5 +34,5 @@ if ! [ -x "$(command -v nvidia-smi)" ]; then | |||
EXTRA_ARGS="-n auto" | |||
fi | |||
|
|||
|
|||
bazel clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanpmorgan I want to remove this but if I remove this it find some so
in the cache that I don't understands where it comes from:
`
tensorflow.python.framework.errors_impl.NotFoundError: /addons/bazel-bin/tensorflow_addons/custom_ops/layers/lib_correlation_cost_ops_gpu.so: undefined symbol: _ZNK10tensorflow6Tensor21CheckTypeAndIsAlignedENS_8DataTypeE
In the local build I don't find any lib_correlation_cost_ops_gpu.so
Just as a reminder note: |
@@ -9,4 +9,4 @@ docker build \ | |||
--build-arg TF_VERSION=2.2.0 \ | |||
--build-arg PY_VERSION=3.5 \ | |||
-t tfa_gpu_tests ./ | |||
docker run --rm -t -v cache_bazel:/root/.cache/bazel --gpus=all tfa_gpu_tests | |||
docker run --rm -t --gpus=all tfa_gpu_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working so I don't know if anybody remember why the bazel cache volume was required here but we could revert this change.
Could you give a bit of background to help us understand what you want to enable with this pull request? |
@seanpmorgan knows a little bit more the context of this cause it is partially related to #1888 but it doesn't depend on that. When you develop in a container env generally and/or you are integrating in the IDO you don't want to have to much manual steps on bash scripts or have in you source tree files produced in the container environment like when you mount in the container your With this we are trying to detect if we are in "developer mode" so that we don't need to continuously manually run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks. Apologies for the very slow review. I was debating if we could avoid users paying this dev tool directory lookup, but it's minimal and done only when a custom op is called for the first time.
No description provided.