Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PoincareNormalize #20

Merged
merged 3 commits into from
Jan 26, 2019

Conversation

facaiy
Copy link
Member

@facaiy facaiy commented Jan 17, 2019

Fix #10

@seanpmorgan
Copy link
Member

LGTM. Needs a decision on the discussion from #19 though I believe

@facaiy
Copy link
Member Author

facaiy commented Jan 21, 2019

Thank you, Sean :-)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@seanpmorgan
Copy link
Member

@facaiy Are you okay with the changes to #19 and #20? If so I'll merge and we can make another issue for building a registration mechanism.

@facaiy
Copy link
Member Author

facaiy commented Jan 26, 2019

Good idea! Looks greater, thanks, Sean :-)

@seanpmorgan seanpmorgan merged commit f4c11b4 into tensorflow:master Jan 26, 2019
@facaiy facaiy deleted the ENH/PoincareNormalize branch January 27, 2019 03:42
Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants