Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure tf.functions can't have None inputs #2837

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

faizan-m
Copy link
Member

Description

Brief Description of the PR:
Using experimental_implements feature now enforces purity on tf.function (all inputs must be Tensors). However, the default value here is None which is not allowed.

Fixes # (issue)

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@faizan-m faizan-m requested a review from WindQAQ as a code owner June 20, 2023 21:37
@boring-cyborg boring-cyborg bot added the image label Jun 20, 2023
@bhack bhack self-requested a review June 21, 2023 13:37
@bhack bhack merged commit 877c0b2 into tensorflow:master Jun 21, 2023
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants