Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set permissions to GITHUB_TOKEN #2848

Merged
merged 3 commits into from Sep 12, 2023
Merged

Set permissions to GITHUB_TOKEN #2848

merged 3 commits into from Sep 12, 2023

Conversation

joycebrum
Copy link
Contributor

Description

Setting GITHUB_TOKEN permissions for all workflows.
I was not sure how to flag the type of change.

Fixes #2847

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

The permissions were mostly generated from the Step Security tool, which has a database for actions needed permissions. To the workflows that used github api calls, I've checked the needed permissions by looking at https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview

Signed-off-by: Joyce Brum <joycebrum@google.com>
Signed-off-by: Joyce <joycebrum@google.com>
Signed-off-by: Joyce <joycebrum@google.com>
@boring-cyborg boring-cyborg bot added the github label Sep 12, 2023
@bhack
Copy link
Contributor

bhack commented Sep 12, 2023

/cc @mihaimaruseac

@mihaimaruseac
Copy link

Need someone from addons to merge it

@bhack bhack self-requested a review September 12, 2023 20:38
@bhack
Copy link
Contributor

bhack commented Sep 12, 2023

@mihaimaruseac Thank you for the check

@bhack bhack merged commit 664ac01 into tensorflow:master Sep 12, 2023
58 of 59 checks passed
@seanpmorgan
Copy link
Member

tyvm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set permissions to GITHUB_TOKEN
4 participants