Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against TF 2.15 #2857

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

seanpmorgan
Copy link
Member

No description provided.

@boring-cyborg boring-cyborg bot added the github label Nov 20, 2023
@seanpmorgan seanpmorgan changed the title Build against TF 2.15 [WIP] Build against TF 2.15 Nov 20, 2023
@seanpmorgan
Copy link
Member Author

Looks like a header is missing for Windows TF2.15:
tensorflow/tensorflow#61830

@bhack @angerson I think intel builds the windows whls now?

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Nov 26, 2023

I lean toward dropping Windows support until upstream is fixed. Alternative is to build against TF2.14 for windows with the risk of segfaults in windows custom ops due to incompatible abi

@bhack
Copy link
Contributor

bhack commented Nov 26, 2023

Yes I agree to remove it at least if something will not change with this ticket:

tensorflow/tensorflow#59918

I think that the Intel team can release a window version of Addons compatible with their window TF artifacts if requested.

@seanpmorgan seanpmorgan changed the title [WIP] Build against TF 2.15 Build against TF 2.15 Nov 27, 2023
@bhack
Copy link
Contributor

bhack commented Nov 27, 2023

I think we could add a string in the Readme.

@seanpmorgan
Copy link
Member Author

I think we could add a string in the Readme.

Added. Hoping that we can just add it back with a patch release but the issue is a few months old now without any sign of fix coming

@bhack
Copy link
Contributor

bhack commented Nov 27, 2023

Added. Hoping that we can just add it back with a patch release but the issue is a few months old now without any sign of fix coming

Yes we could just subscribe to the upstream ticket.

@seanpmorgan seanpmorgan merged commit 062a7aa into tensorflow:master Nov 28, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants