Fix tf-addons for upcoming keras 3 default. #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cantonios
requested review from
qlzh727,
guillaumekln and
WindQAQ
as code owners
|
@howl-anderson @pedrolarben @SSaishruthi @hyang0129 You are owners of some files modified in this pull request. |
Keras 3.0 will become default in TF 2.16 (and is currently default in tf-nightly). This breaks this tf-addons package. Here we make minimal changes to return functionality in a backward-compatible way.
qlzh727
reviewed
Dec 12, 2023
| @@ -149,3 +149,6 @@ def _resource_scatter_operate(self, resource, indices, update, resource_scatter_ | |||
| } | |||
|
|
|||
| return resource_scatter_op(**resource_update_kwargs) | |||
|
|
|||
| def get_config(self): | |||
There was a problem hiding this comment.
Yes, with keras 3 it throws an error that LazyAdam doesn't have a get_config method.
| # ============================================================================== | ||
| """Base class for RNN cells. | ||
|
|
||
| Adapted from legacy github.com/keras-team/tf-keras. |
There was a problem hiding this comment.
What's the reason this is needed? Is it because of the usage of tf.keras.layers?
There was a problem hiding this comment.
The AbstractRNNCell only exists in tf_keras (it previously existed in keras 2, but doesn't exist in keras 3).
qlzh727
approved these changes
Dec 12, 2023
seanpmorgan
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keras 3.0 will become default in TF 2.16 (and is currently default in tf-nightly). This breaks this tf-addons package. Here we make minimal changes to return functionality in a backward-compatible way.
Fixes # (issue)
None known reported.
Type of change
Checklist:
How Has This Been Tested?
Imported with tf-nightly, keras-nightly, tf_keras-nightly, setting both
TF_USE_LEGACY_KERAS=0and1.