Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF2 WeightNormalization #29

Merged
merged 5 commits into from
Feb 14, 2019
Merged

Conversation

seanpmorgan
Copy link
Member

Various changes to better fit TF2

Copy link
Member

@facaiy facaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I leave a few comments here :-)

tensorflow_addons/layers/python/wrappers.py Show resolved Hide resolved
tensorflow_addons/layers/python/wrappers.py Outdated Show resolved Hide resolved
tensorflow_addons/layers/python/wrappers.py Show resolved Hide resolved
tensorflow_addons/layers/python/wrappers_test.py Outdated Show resolved Hide resolved
@facaiy facaiy self-assigned this Feb 14, 2019
@facaiy
Copy link
Member

facaiy commented Feb 14, 2019

Is the py3 failures related? It seems that we cannot see the Details page.

@facaiy facaiy merged commit 4aedd36 into tensorflow:master Feb 14, 2019
@seanpmorgan seanpmorgan deleted the tf2-weightnorm branch February 14, 2019 02:04
tabshaikh pushed a commit to tabshaikh/addons that referenced this pull request Feb 18, 2019
* FIX: Modify WeightNormalization for TF2

* FIX: Update bazel tests

* FIX: Modify WeightNormalization for TF2

* FIX: Modify WeightNormalization for TF2
Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
* FIX: Modify WeightNormalization for TF2

* FIX: Update bazel tests

* FIX: Modify WeightNormalization for TF2

* FIX: Modify WeightNormalization for TF2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants