BLD: Update environment to ubuntu16.04 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop support for py34
This was referenced Aug 4, 2019
Merged
# Conflicts: # build_deps/gpu/cuda/BUILD.tpl # build_deps/requirements.txt # build_deps/requirements_gpu.txt # tools/ci_build/builds/release_linux.sh # tools/ci_build/builds/release_macos.sh
seanpmorgan
changed the title
WindQAQ
reviewed
Aug 11, 2019
| @@ -1 +1 @@ | |||
| tf-nightly-gpu-2.0-preview==2.0.0.dev20190731 | |||
| tf-nightly-gpu-2.0-preview>=2.0.0.dev20190802 | |||
There was a problem hiding this comment.
is this related to #407 so we do not pin to latest version?
There was a problem hiding this comment.
So this is the date when tensorflow began publishing manylinux2010 whls. The greater or equal to will need to stay so I added a comment to the files. Thanks!
WindQAQ
added
awaiting testing (then merge)
kokoro:force-run
and removed
kokoro:force-run
labels
Lint Add missing files Create crosstool_wrapper_driver_is_not_gcc.tpl Create msvc_wrapper_for_nvcc.py.tpl Update permission
seanpmorgan
force-pushed
the
bld-ubuntu16
branch
from
7d562d2
to
3f8dbd9
Compare
seanpmorgan
commented
Aug 11, 2019
| @@ -466,7 +466,8 @@ def _testWithMaybeMultiAttention(self, | |||
| expected_final_alignment_history, | |||
| final_alignment_history_info) | |||
|
|
|||
| @parameterized.parameters([np.float32, np.float64]) | |||
| # TODO: #407 Float64 test is failing | |||
|
@tensorflow/sig-addons-maintainers Fixed the issues... ready for review. |
WindQAQ
reviewed
Aug 12, 2019
| @@ -44,6 +44,7 @@ function main() { | |||
| cp ${PIP_FILE_PREFIX}setup.py "${TMPDIR}" | |||
| cp ${PIP_FILE_PREFIX}MANIFEST.in "${TMPDIR}" | |||
| cp ${PIP_FILE_PREFIX}LICENSE "${TMPDIR}" | |||
| touch ${TMPDIR}/stub.cc | |||
There was a problem hiding this comment.
Sean, I don't find where we use this file. Could you point out the place or it is just for testing?
There was a problem hiding this comment.
Yeah good find... without that sort-of hack the whl fails manylinux2010 compliance because:
RuntimeError: Invalid binary wheel, found the following shared library/libraries in purelib folder: ... The wheel has to be platlib compliant in order to be repaired by auditwheel.
This is the same patch as is done on TF-Core:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/devtoolset/platlib.patch
WindQAQ
approved these changes
Aug 12, 2019
lgeiger
added a commit
to larq/compute-engine
that referenced
this pull request
Feb 14, 2020
Since we ship compiled *.so files without the source C++ code this is necessary to appease auditwheel. This is dark magic copied from tensorflow/addons#389 and https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/devtoolset/platlib.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing to close #75 and #119 now that the docker containers are available. At the moment the packaged whls are failing manylinux2010 compliance but it could be because we link to the tf-nightly which is not yet built in this env. The switch for nightlies on core should be within a couple weeks.
Also need to setup the cuda crosstool (though we haven't finalized our gpu pip package):
tensorflow/custom-op@b74be35
Another note: this will drop py34 support as tf-core has done the same.