add hardshrink kernel #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindQAQ
requested review from
facaiy,
seanpmorgan and
a team
as code owners
seanpmorgan
requested changes
Sep 12, 2019
|
|
||
| #define REGISTER_HARDSHRINK_KERNELS(type) \ | ||
| REGISTER_KERNEL_BUILDER( \ | ||
| Name("Hardshrink").Device(DEVICE_CPU).TypeConstraint<type>("T"), \ |
There was a problem hiding this comment.
Think we could change this to Addons>Hardshrink per tensorflow/community#126 ? It should work on the nightly and RC I believe.
There was a problem hiding this comment.
I wonder how to do this... I have tried to modify cc/kernels/hardshrink_op.cc and cc/ops/hardshrink_op.cc, but none of them gives the answer. I think I could just follow @tomerk's PR though.
tomerk
pushed a commit
to tomerk/addons
that referenced
this pull request
Sep 17, 2019
* add hardshrink kernel * make linter happy
facaiy
pushed a commit
that referenced
this pull request
Sep 19, 2019
* Namespaced all of the custom ops * Updated C++ namespaces to not conflict w/ TF contrib ones * Ran code reformatting tool * Port bug fix in TF contrib to addons. (#497) * Port bug fix in TF contrib to addons. Original change at tensorflow/tensorflow@a913689. * Fix lint warning. * check pass through and do the expand_dims() only if needed (#464) * check pass through and do the expand_dims() only if needed * add indent to the fixed line * merge return condition to if state * add hardshrink kernel (#500) * add hardshrink kernel * make linter happy * Fixing SequenceLoss Keras incompatibility (#503) * Fix SequenceLoss incompatibility with Keras built-in loops * Remove debugging prints * Change the attribute existence checking to use more pythonic way * Replace some compat.v1 APIs by their v2 equivalent (#507) * Replace some compat.v1 APIs by their v2 equivalent * Fix lint error * Add documentation for LazyAdam (#515) * Updated hardshrink custom ops & made #ifdef names more consistent. * Fix to undef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hardshrink kernel:
x if x < lower or x > upper else 0.