Migrate distort image ops #67
Conversation
facaiy
requested review from
facaiy,
seanpmorgan and
armando-fandango
and removed request for
facaiy
|
Thank you, @WindQAQ . Would you mind merging the latest master branch and run |
|
Done :-) |
tensorflow_addons/custom_ops/image/python/distort_image_ops_test.py
Outdated
Show resolved
Hide resolved
tensorflow_addons/custom_ops/image/python/distort_image_ops_test.py
Outdated
Show resolved
Hide resolved
| self._adjust_saturation_in_yiq_tf(x_np, scale) | ||
|
|
||
|
|
||
| class AdjustHueInYiqBenchmark(tf.test.Benchmark): |
There was a problem hiding this comment.
@karmel Hi, Karmel. Do you know what's the future for Benchmark class in tf 2.0?
| #include "tensorflow/core/util/work_sharder.h" | ||
| #include "tensorflow_addons/custom_ops/image/cc/kernels/adjust_hsv_in_yiq_op.h" | ||
|
|
||
| namespace tensorflow { |
There was a problem hiding this comment.
@seanpmorgan @karmel I'm wondering if we can still use tensorflow namespace? What do you think?
tensorflow_addons/custom_ops/image/python/distort_image_ops_test.py
Outdated
Show resolved
Hide resolved
|
Similar to #53, some assertions do not raise when |
|
Because tf 2.0 is still in the developing process (and addons too), we might run into problems as no surprise, and then have to discuss how to deal with it in the best way. Most time-consuming part for review, we really appreciate your patience, Tzu-Wei ! |
Could you leave a TODO comment? I don't want to delay the PR, and I think we can fix it later with #53. cc @seanpmorgan What do you think, Sean? |
|
Added TODO comments on |
tensorflow_addons/custom_ops/image/python/distort_image_ops_test.py
Outdated
Show resolved
Hide resolved
tensorflow_addons/custom_ops/image/python/distort_image_ops_test.py
Outdated
Show resolved
Hide resolved
|
Tzu-Wei, feel free to ping me when you get all done ( and don't forget to use |
|
Hi @facaiy, already made requested changes! |
|
Many thanks, Tzu-Wei! |
* migrate distort_image_ops * add test for distort_image_ops * modify BUILD file for distort_image_ops * add tf.fucntion decorator * fix assert regex * clean up internal api * update README * fix copyright * import *_hsv_in_yiq * fix name scope error * code format * remove sessions * fix wrong decorators * add TODO comments * remove tf_test_util * clean up messy stuff
Address #25.
distort_image_ops*containrandom_hsv_in_yiqandadjust_hsv_in_yiq. Not sure if the benchmark functions indistort_image_ops_test.pyshould be removed or not.