-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tf function where unecessary #823
Remove tf function where unecessary #823
Conversation
Just a note, have to update the README.md about |
# Conflicts: # tensorflow_addons/activations/rrelu_test.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleanup! My only concern is that test_unknown_shape
for image tests is designed for tf.data.Dataset
. If we get rid of tf.function
, will it always be compatible for tf.data.Dataset
? Moreover, a old thread tensorflow/tensorflow#27811 mentioned that tf.function
will be apply automatically for tf.data.Dataset.map
for TF2.0.
A trivial test is to use something like
fn = tf.function(dist_ops.euclidean_dist_transform).get_concrete_function(
tf.TensorSpec(None, tf.uint8))
to make sure it would be compatible with tf.data.Dataset
.
What do you think, Sean?
Thanks good catch.. i've added them back. I was also thinking we should have subpackage test suites similar to |
ad3fae0
to
7cc3d36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #807
Removed from: