Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Java Repositories #131

Merged
merged 3 commits into from Sep 10, 2019
Merged

Conversation

karllessard
Copy link
Contributor

@karllessard karllessard commented Aug 7, 2019

Comment period is open through 2019-08-30

RFC: Java Repositories

Status Proposed
Author Karl Lessard (karl.lessard@gmail.com)
Sponsor James Ring (Google)
Updated 2019-08-02

Objective

Create new repositories under the github.com/tensorflow organization to host the code supported by SIG JVM, including the actual Java client found in TensorFlow core repository.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@karllessard karllessard changed the title (SIG JVM) Java Repository RFC [SIG JVM] Java Repository RFC Aug 7, 2019
@karllessard karllessard changed the title [SIG JVM] Java Repository RFC [SIG JVM] Java Repositories RFC Aug 7, 2019
@karllessard
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 7, 2019
@ewilderj ewilderj added the RFC: Proposed RFC Design Document label Aug 16, 2019
@ewilderj ewilderj added this to Needs attention in RFC management via automation Aug 16, 2019
@ewilderj ewilderj changed the title [SIG JVM] Java Repositories RFC RFC: Java Repositories Aug 16, 2019
@ewilderj ewilderj moved this from Needs attention to Open reviews in RFC management Aug 22, 2019
@karllessard
Copy link
Contributor Author

I just asked the SIG JVM group if they would prefer to rename the repositories to "/tensorflow/jvm" and "/tensorflow/jvm-models", instead of their "java" counterpart.

Sounds like "jvm" makes more sense if we intend to host code and samples for JVM languages other than Java in those repos as well. Waiting to be confirmed.

CC: @ewilderj

@ewilderj
Copy link
Contributor

ewilderj commented Sep 2, 2019

This might add a couple more days as I need to revisit the required repo names, but shouldn't be too much of a delay. Is it the consensus of the group that jvm is preferred to 'java'? If so, we ought to push an update to this RFC as well.

cc @martinwicke for any opinions

@karllessard
Copy link
Contributor Author

karllessard commented Sep 2, 2019 via email

@saudet
Copy link

saudet commented Sep 3, 2019

@ewilderj What do the teams at Google usually do for polls like this?

@ewilderj
Copy link
Contributor

ewilderj commented Sep 3, 2019

@ewilderj What do the teams at Google usually do for polls like this?

Google Forms!

btw we now have approval for making the java and java-models repos. I suggest we make these and treat any renaming as a second step.

@karllessard
Copy link
Contributor Author

@ewilderj : ok, you know better what it implies to apply those changes than we do so if you think it would be easier to rename them after, then let’s go for it!

@karllessard
Copy link
Contributor Author

@ewilderj, like any good ol' survey, the result is a tie: half wants to preserve "java" and half wants to rename it to "jvm".

Therefore, I guess the status quo wins, which is to keep the original "/java" and "/java-models" names.

@ewilderj
Copy link
Contributor

ewilderj commented Sep 9, 2019

The repositories are now made. @karllessard @sjamesr and @tzolov you have invitations to the @tensorflow/sig-jvm-maintainers team, which will give you write perms on the repo. Work can commence!

@karllessard please push an update to this PR changing Status to "Accepted", then I will merge this RFC as part of the record.

@karllessard
Copy link
Contributor Author

karllessard commented Sep 9, 2019 via email

@ewilderj ewilderj added RFC: Accepted RFC Design Document: Accepted by Review and removed RFC: Proposed RFC Design Document labels Sep 10, 2019
@ewilderj ewilderj merged commit 91703f6 into tensorflow:master Sep 10, 2019
RFC management automation moved this from Open reviews to Accepted RFCs Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes RFC: Accepted RFC Design Document: Accepted by Review
Projects
RFC management
  
Accepted RFCs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants