New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Java Repositories #131
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I just asked the SIG JVM group if they would prefer to rename the repositories to "/tensorflow/jvm" and "/tensorflow/jvm-models", instead of their "java" counterpart. Sounds like "jvm" makes more sense if we intend to host code and samples for JVM languages other than Java in those repos as well. Waiting to be confirmed. CC: @ewilderj |
This might add a couple more days as I need to revisit the required repo names, but shouldn't be too much of a delay. Is it the consensus of the group that jvm is preferred to 'java'? If so, we ought to push an update to this RFC as well. cc @martinwicke for any opinions |
Yeah, sorry for the trouble, I just poked the SIG this morning to see if
they have a preference, I'll keep you posted shortly of our final decision
(I'll try to know before for Wednesday).
Thanks,
Karl
Le lun. 2 sept. 2019, à 16 h 16, Edd Wilder-James <notifications@github.com>
a écrit :
… This might add a couple more days as I need to revisit the required repo
names, but shouldn't be too much of a delay. Is it the consensus of the
group that jvm is preferred to 'java'? If so, we ought to push an update to
this RFC as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#131?email_source=notifications&email_token=ACNEEXQ4YU2FXDDML3A4VXLQHVYALA5CNFSM4IJ3L3FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WP3KA#issuecomment-527236520>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACNEEXXKK42YBY6SBFDRHMLQHVYALANCNFSM4IJ3L3FA>
.
|
@ewilderj What do the teams at Google usually do for polls like this? |
Google Forms! btw we now have approval for making the java and java-models repos. I suggest we make these and treat any renaming as a second step. |
@ewilderj : ok, you know better what it implies to apply those changes than we do so if you think it would be easier to rename them after, then let’s go for it! |
@ewilderj, like any good ol' survey, the result is a tie: half wants to preserve "java" and half wants to rename it to "jvm". Therefore, I guess the status quo wins, which is to keep the original "/java" and "/java-models" names. |
The repositories are now made. @karllessard @sjamesr and @tzolov you have invitations to the @tensorflow/sig-jvm-maintainers team, which will give you write perms on the repo. Work can commence! @karllessard please push an update to this PR changing Status to "Accepted", then I will merge this RFC as part of the record. |
Wonderful, that’s very good news, thanks Edd!!
… On Sep 9, 2019, at 15:16, Edd Wilder-James ***@***.***> wrote:
The repositories are now made. @karllessard @sjamesr and @tzolov you have invitations to the @tensorflow/sig-jvm-maintainers team, which will give you write perms on the repo. Work can commence!
@karllessard please push an update to this PR changing Status to "Accepted", then I will merge this RFC as part of the record.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@ewilderj : moved the **Accepted**
Comment period is open through 2019-08-30
RFC: Java Repositories
Objective
Create new repositories under the
github.com/tensorflow
organization to host the code supported by SIG JVM, including the actual Java client found in TensorFlow core repository.