Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Embedding and Partitioned Variables in TF 2.0 #55

Merged
merged 11 commits into from Feb 4, 2019
Merged

RFC: Embedding and Partitioned Variables in TF 2.0 #55

merged 11 commits into from Feb 4, 2019

Commits on Jan 17, 2019

  1. Configuration menu
    Copy the full SHA
    ec9f7a0 View commit details
    Browse the repository at this point in the history
  2. Fix one formatting issue.

    yuefengz committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    25a9c17 View commit details
    Browse the repository at this point in the history
  3. Fix another formatting issue.

    yuefengz committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    961e242 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05e6343 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Make clear distinction between embedding variables and loadbalancing

    variables.
    yuefengz committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    850cc78 View commit details
    Browse the repository at this point in the history
  2. Add a paragraph pointing out the problem with the `partition_strategy…

    …` argument.
    Yuefeng Zhou committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    c15370c View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Update alternatives since DynamicPartition and DynamicStitch do h…

    …ave GPU kernels.
    Yuefeng Zhou committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    f950423 View commit details
    Browse the repository at this point in the history
  2. Add a section for saving and restore PartitionedVariable.

    Yuefeng Zhou committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    e23208e View commit details
    Browse the repository at this point in the history
  3. Mention that variable types can be nested, attention needs to be paid…

    … to their saving and restoring mechanism.
    Yuefeng Zhou committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    4d454c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Update according to the discussion

    * Move performance heuristics in Distribution Strategy level. We will not expose knobs for users to control;
    * Emphasize that embedding support in v2 will all be via `Embedding` layer. Users can use `tf.compat.v1` to handle embedding by themselves;
    * Mention that default `partition_strategy` in v1 `embedding_lookup` is "mod", which will possibly break users's model when they update to TF 2.0;
    * We want to prioritize shuffling embedding after 2.0 release;
    * We have plans to serialize and deserialize `Embedding` layer and Distribution Strategies to allow loading a saved model to a different number of partitions.
    Yuefeng Zhou committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    fb6a161 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Change to accepted

    Yuefeng Zhou committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    a3c96c1 View commit details
    Browse the repository at this point in the history