Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker information #1023

Merged
merged 7 commits into from Sep 18, 2019

Conversation

akindofyoga
Copy link
Contributor

The statement "nvidia-docker is not necessary" is incorrect. The nvidia-docker and nvidia-docker2 packages are deprecated because the Docker runtime naively supports NVIDIA GPUs. But Docker does not support Nvidia GPUs on its own. The nvidia-container-runtime is still required.

Updated all Docker commands to use the command line flags that nvidia-container-toolkit uses. All users with fresh installations will be using nvidia-container-toolkit instead of nvidia-docker v2.

The original statement here did not seem correct
The statement "`nvidia-docker` is not necessary" is incorrect. The `nvidia-docker` and `nvidia-docker2` packages are deprecated because the Docker runtime naively supports NVIDIA GPUs. But Docker does not support Nvidia GPUs on its own. The `nvidia-container-runtime` is still required.

Updated all Docker commands to use the command line flags that nvidia-container-toolkit uses. All users with fresh installations will be using nvidia-container-toolkit instead of `nvidia-docker` v2.
@googlebot googlebot added the cla: yes CLA has been signed label Sep 17, 2019
@tfdocsbot tfdocsbot added kokoro:force-run lgtm Community-added approval labels Sep 18, 2019
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@lamberta lamberta added the ready to pull Start merge process label Sep 18, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Sep 18, 2019
PiperOrigin-RevId: 269851852
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 635bcca into tensorflow:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
7 participants