Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KO: add site/ko/guide/eager.ipynb #1046

Merged
merged 15 commits into from Oct 4, 2019

Conversation

@wckim
Copy link
Contributor

commented Sep 26, 2019

added guide doc is korean translation of site/en/guide/eager.ipynb

@wckim wckim requested review from lamberta and MarkDaoust as code owners Sep 26, 2019
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

Reviewers added, please take a look.
@rickiepark, @cre8tor, @Choiuijin1125, @JKIsaacLee, @NoelBird

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes label Sep 26, 2019
@rickiepark

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

Thank you @wckim , I'll start to review. :)

Copy link
Contributor

left a comment

Hi @wckim

It's great translation. Most sentences are reasonable.
Please check my comments. :)

It's quite a long, so I continue to review later.
Thank you!

site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

Thank you @wckim. 👍 👍 👍
Please check my comments.

site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
@wckim

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Some sections were added and some words were changed after the commit used for this translation.
I will translate the section and other content(if it is) after syncing ko and en guide document.

@rickiepark

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Thank you! When you finish updating the translation, feel free to let me know. :-)

@wckim

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

I updated this ko document added recent commits of en document.
(and fix some typo)
For the sake of comparison, the indentation size of ko and en doc was aligned.
I just knew the jupyter notebook used for the translation editor changed the indentation size of the ko document.

@wckim

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Finish updating translation of added section 'Summaries and TensorBoard'.
@rickiepark please, resume the review.

Copy link
Contributor

left a comment

Thank you @wckim
It's almost done.
Please check my last comments. 👍

site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
@rickiepark

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Thank you @wckim.
Translation is not easy work.
Your contribution may helps people learn TensorFlow.
LGTM 👍

@wckim

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Thank you @rickiepark
Yes... Yes... the translation is not easy work.. :)
Your great reviews made my translation more helpful.

Copy link
Member

left a comment

Thanks for the translation and review! 🚀
This is a great doc to translate

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Oct 4, 2019
PiperOrigin-RevId: 272972767
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 33b8824 into tensorflow:master Oct 4, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.