Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KO: add site/ko/guide/eager.ipynb #1046

Merged
merged 15 commits into from Oct 4, 2019
Merged

KO: add site/ko/guide/eager.ipynb #1046

merged 15 commits into from Oct 4, 2019

Conversation

wckim
Copy link
Contributor

@wckim wckim commented Sep 26, 2019

added guide doc is korean translation of site/en/guide/eager.ipynb

@tfdocsbot
Copy link
Collaborator

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@tfdocsbot tfdocsbot added ko translation Community-provided translation for certain languages labels Sep 26, 2019
@tfdocsbot
Copy link
Collaborator

Reviewers added, please take a look.
@rickiepark, @cre8tor, @Choiuijin1125, @JKIsaacLee, @NoelBird

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes CLA has been signed label Sep 26, 2019
@rickiepark
Copy link
Contributor

Thank you @wckim , I'll start to review. :)

Copy link
Contributor

@rickiepark rickiepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wckim

It's great translation. Most sentences are reasonable.
Please check my comments. :)

It's quite a long, so I continue to review later.
Thank you!

site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@rickiepark rickiepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wckim. 👍 👍 👍
Please check my comments.

site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
@wckim
Copy link
Contributor Author

wckim commented Oct 4, 2019

Some sections were added and some words were changed after the commit used for this translation.
I will translate the section and other content(if it is) after syncing ko and en guide document.

@rickiepark
Copy link
Contributor

Thank you! When you finish updating the translation, feel free to let me know. :-)

@wckim
Copy link
Contributor Author

wckim commented Oct 4, 2019

I updated this ko document added recent commits of en document.
(and fix some typo)
For the sake of comparison, the indentation size of ko and en doc was aligned.
I just knew the jupyter notebook used for the translation editor changed the indentation size of the ko document.

@wckim
Copy link
Contributor Author

wckim commented Oct 4, 2019

Finish updating translation of added section 'Summaries and TensorBoard'.
@rickiepark please, resume the review.

Copy link
Contributor

@rickiepark rickiepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wckim
It's almost done.
Please check my last comments. 👍

site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
site/ko/guide/eager.ipynb Outdated Show resolved Hide resolved
@rickiepark
Copy link
Contributor

Thank you @wckim.
Translation is not easy work.
Your contribution may helps people learn TensorFlow.
LGTM 👍

@tfdocsbot tfdocsbot added kokoro:force-run lgtm Community-added approval labels Oct 4, 2019
@wckim
Copy link
Contributor Author

wckim commented Oct 4, 2019

Thank you @rickiepark
Yes... Yes... the translation is not easy work.. :)
Your great reviews made my translation more helpful.

Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation and review! 🚀
This is a great doc to translate

@lamberta lamberta added the ready to pull Start merge process label Oct 4, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Oct 4, 2019
PiperOrigin-RevId: 272972767
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 33b8824 into tensorflow:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ko lgtm Community-added approval ready to pull Start merge process translation Community-provided translation for certain languages
Projects
None yet
7 participants