Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: Add site/ja/tutorials/text/nmt_with_attention.ipynb #1276

Conversation

masa-ita
Copy link
Contributor

No description provided.

@tfdocsbot tfdocsbot added ja translation Community-provided translation for certain languages labels Dec 10, 2019
@tfdocsbot
Copy link
Collaborator

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@tfdocsbot
Copy link
Collaborator

Reviewers added, please take a look.
@ohtaman, @sfujiwara, @AseiSugiyama, @yukinagae, @nuka137, @chie8842, @kiszk

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes CLA has been signed label Dec 10, 2019
Copy link
Contributor

@AseiSugiyama AseiSugiyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masa-ita Thank you for your great work, I found no mistakes! I left some comment, please check it.

"source": [
"## データセットのダウンロードと準備\n",
"\n",
"ここでは、http://www.manythings.org/anki/ で提供されている言語データセットを使用します。このデータセットには、次のような書式の言語翻訳ペアが含まれています。\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mistake]
This line contains ZENKAKU space and it causes an issue on making a hyperlink to http://www.manythings.org/anki/ URL. Could you fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AseiSugiyama
Thank you for your review.
I fixed it.

"このチュートリアルでは、エンコーダーでは [Bahdanau attention](https://arxiv.org/pdf/1409.0473.pdf) を使用します。簡略化した式を書く前に、表記方法を定めましょう。\n",
"\n",
"* FC = 全結合 (Dense) レイヤー\n",
"* EO = エンコーダー出力\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[weak suggestion]
'エンコーダー出力' -> 'エンコーダーの出力'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I've changed it.

"* もっと大きなデータセットで訓練を行ったり、もっと多くのエポックで訓練を行ったりしてみよう。"
]
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this empty cell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Removed.

@AseiSugiyama
Copy link
Contributor

@masa-ita Great work! LGTM!

@tfdocsbot tfdocsbot added kokoro:force-run lgtm Community-added approval labels Jan 4, 2020
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@lamberta lamberta added the ready to pull Start merge process label Jan 6, 2020
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jan 6, 2020
…h_attention

PiperOrigin-RevId: 288343935
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit cb095c1 into tensorflow:master Jan 6, 2020
@masa-ita masa-ita deleted the site_ja_tutorials_text_nmt_with_attention branch January 7, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ja lgtm Community-added approval ready to pull Start merge process translation Community-provided translation for certain languages
Projects
None yet
7 participants