New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JA: Add site/ja/tutorials/text/nmt_with_attention.ipynb #1276
JA: Add site/ja/tutorials/text/nmt_with_attention.ipynb #1276
Conversation
…ithub.com/masa-ita/tf-docs into site_ja_tutorials_text_nmt_with_attention
Preview and run these notebook edits with Google Colab: Notebook diffs available on ReviewNB.com. |
Reviewers added, please take a look. When your review is finished, approve the pull request or include "LGTM" in your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masa-ita Thank you for your great work, I found no mistakes! I left some comment, please check it.
"source": [ | ||
"## データセットのダウンロードと準備\n", | ||
"\n", | ||
"ここでは、http://www.manythings.org/anki/ で提供されている言語データセットを使用します。このデータセットには、次のような書式の言語翻訳ペアが含まれています。\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[mistake]
This line contains ZENKAKU space and it causes an issue on making a hyperlink to http://www.manythings.org/anki/ URL. Could you fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AseiSugiyama
Thank you for your review.
I fixed it.
"このチュートリアルでは、エンコーダーでは [Bahdanau attention](https://arxiv.org/pdf/1409.0473.pdf) を使用します。簡略化した式を書く前に、表記方法を定めましょう。\n", | ||
"\n", | ||
"* FC = 全結合 (Dense) レイヤー\n", | ||
"* EO = エンコーダー出力\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[weak suggestion]
'エンコーダー出力' -> 'エンコーダーの出力'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I've changed it.
"* もっと大きなデータセットで訓練を行ったり、もっと多くのエポックで訓練を行ったりしてみよう。" | ||
] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this empty cell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Removed.
@masa-ita Great work! LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
…h_attention PiperOrigin-RevId: 288343935
No description provided.