Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in 'time_series.ipynb' notebook #1647

Conversation

tallamjr
Copy link
Contributor

@tallamjr tallamjr commented Aug 10, 2020

  1. 'widow' --> 'window'

  2. 'batch of 2' --> 'batch of 3'

# Stack three slices, the length of the total window:
example_window = tf.stack([np.array(train_df[:w2.total_window_size]),
                           np.array(train_df[100:100+w2.total_window_size]),
                           np.array(train_df[200:200+w2.total_window_size])])

The above snippet relating to change 2. shows three slices, implying m = 3,
i.e. 'batch of 3' instead of 2

modified:   site/en/tutorials/structured_data/time_series.ipynb

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA has not been signed label Aug 10, 2020
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch/site/en/tutorials/structured_data/time_series.ipynb

tallamjr and others added 2 commits August 10, 2020 09:52
1. 'widow' --> 'window'

2. 'batch of 2' --> 'batch of 3'

"# Stack three slices, the length of the total window:",
example_window = tf.stack([np.array(train_df[:w2.total_window_size]),
                           np.array(train_df[100:100+w2.total_window_size]),
                           np.array(train_df[200:200+w2.total_window_size])])

The above snippet relating to change 2. shows three slices, implying m = 3,
i.e. 'batch of 3' instead of 2

	modified:   site/en/tutorials/structured_data/time_series.ipynb
@tallamjr tallamjr force-pushed the patch/site/en/tutorials/structured_data/time_series.ipynb branch from 6a4e16c to 330cdd5 Compare August 10, 2020 08:55
@tallamjr
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Aug 10, 2020
@github-actions github-actions bot added the lgtm Community-added approval label Aug 10, 2020
@MarkDaoust MarkDaoust added ready to pull Start merge process and removed lgtm Community-added approval labels Aug 10, 2020
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 811150f into tensorflow:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ready to pull Start merge process
Projects
None yet
5 participants