Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: translation /ja/install #442

Closed
wants to merge 2 commits into from
Closed

JA: translation /ja/install #442

wants to merge 2 commits into from

Conversation

yukinagae
Copy link
Contributor

@yukinagae yukinagae commented Mar 31, 2019

I've translated the content under ja/install*.

Any feedback or comment would be appreciated :)

@googlebot googlebot added the cla: yes CLA has been signed label Mar 31, 2019
@lamberta lamberta added the translation Community-provided translation for certain languages label Apr 1, 2019
@yukinagae yukinagae marked this pull request as ready for review April 6, 2019 15:03
@lamberta
Copy link
Member

lamberta commented Apr 6, 2019

Thanks you, Yuki, this is great.
Let me think a little on this because we need to figure out a good way to keep this section in sync with the en/ version. For tutorials and guides, these can be a bit out of date and still be useful. But for the /install section, it's very important we show the latest instructions, so we need to come up with a way t maintain this. Will see if we can come up with something.

@yukinagae
Copy link
Contributor Author

@lamberta OK, that makes sense. Hope we can come up with some good ideas. At the moment, I can work on translating other sections I guess.

@lamberta
Copy link
Member

lamberta commented Apr 7, 2019

Thanks, Yuki. I think this can be handled with a simple preprocessing step and a variable ot two. Did you come across anything besides $TENSORFLOW_VERSION that we would need to account for?


成功: TensorFlowがインストールできました。[チュートリアル](../tutorials)を読んで始めましょう。

もう少しTensorFlowのDockerレシピをデモをしましょう。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「...レシピを使ったデモをしましょう」 will be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment, mattn. Which of the following sentences is better?

  • 「もう少しTensorFlowのDockerのレシピを使ったデモをしましょう」
  • 「もう少しTensorFlowのDockerの使い方を見てみましょう」

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original sentense use demonstrate so I prefer the second. (but this is just my optinion. Using "を" twice bothers me) :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@yukinagae
Copy link
Contributor Author

@lamberta Thanks for your reply, Billy. I think your idea is feasible and straightforward, and it must be the way we can go forward. One point I can add it is there may be the chances we have to change some of the content of installation, not only TensorFlow versions but also the issues and instructions regarding specific versions.

@yukinagae
Copy link
Contributor Author

@lamberta Any update on this?

Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, Yuki.
Haven't had time to look into this much, but maybe you have a sense of what variables are needed?
If you can use{{ TENSORFLOW_VERSION }} that that's replaced by "1.13" (or whatever is current), how far will that get you?

Things I'm considering: community translated pages don't really have an "owner" or someone responsible for making sure they are current. If these pages are not updated when a new TensorFlow release is out, what are the consequences? And how should I make that easier? This will take more thought and possibly an RFC because it could affect how we proceed for all community translations.

@@ -0,0 +1,311 @@
# Build and install error messages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this file. This will be difficult to keep in sync with the en/ source-of-truth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, I'll do it.

@lamberta
Copy link
Member

Looping in @sfujiwara, @ohtaman for ideas

@lamberta lamberta added the ja label Apr 23, 2019
@sfujiwara
Copy link
Contributor

OK, I started to review them. But, I need some days because the diff is so large. Please wait for it.

@sfujiwara
Copy link
Contributor

@yukinagae I did check docker.md and gpu.md. But, I'm sorry that it's a little bit tough to review this PR all at once. I think it's not good to take long time to merge this PR. Could you split this PR to each files?

@lamberta How do you think about the above idea?

@yukinagae
Copy link
Contributor Author

@sfujiwara Sorry for the late reply. I've been away from this issue and just noticed your comment.
I understand that this PR is too big for you to review. I'll try to split this PR to small PRs.

Thanks anyway!

@yukinagae
Copy link
Contributor Author

@sfujiwara I made a small PR here, #643.

If it is OK, I will make other small PRs as well such as gpu, c/go/java so on.

@yukinagae
Copy link
Contributor Author

@yukinagae
Copy link
Contributor Author

@lamberta

This PR is closed regarding your post below:

TLDR: Please do not translate the install/ section or *.yaml files (_book.yaml/_toc.yaml/_index.yaml) for Japanese, Korean, or Chinese

https://groups.google.com/a/tensorflow.org/d/msg/docs-ja/f4Vh66EnPpo/2PgmziVrAgAJ

@yukinagae yukinagae closed this Jul 15, 2019
@yukinagae yukinagae deleted the site_ja_install branch November 18, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ja translation Community-provided translation for certain languages
Projects
None yet
5 participants