New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVIDIA updated their machine learning repos #642
Conversation
fix wrong version numbers - libcudnn is still working with old numbers but libnvinfer5 is not
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
</code> | ||
|
||
# Install TensorRT. Requires that libcudnn7 is installed above. | ||
<code class="devsite-terminal">sudo apt-get update && \ | ||
sudo apt-get install nvinfer-runtime-trt-repo-ubuntu1804-5.0.2-ga-cuda10.0 \ | ||
&& sudo apt-get update \ | ||
&& sudo apt-get install -y --no-install-recommends libnvinfer-dev=5.0.2-1+cuda10.0 | ||
&& sudo apt-get install -y --no-install-recommends libnvinfer-dev=5.1.5-1+cuda10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newest library version
hey i know you are busy but this is important information for people trying to install TensorRT - it won't work with wrong version numbrs of libnvinfer5 |
I see a cuDNN specific for CUDA 10 (I suspect same binary or similar) in the downloads. I did not check the repo; could you check again. I realized it is not upgrading to CUDA 10.1 but it would avoid any visual confusion if it was just CUDA 10.0. I am adding lambda who can verify what version of TensorRT we should be suggesting. We also will want to upgrade our docker images. I have been wanting to stay on cuDNN 7.5; but if we need to move forward for TensorRT then that is a valid reason. |
Docs team, you may (not passive aggressive honestly asking) want to change some permissions because I could not add lambda to review this. Not sure if that is desired; it was a bit of a road block/speed bump. |
I think we can also add collaborators to the repo and assign as reviewers? |
I should note: even with write access, I can not assign users that are not in these collaborator teams |
Just checked repo permissions. |
works too its the same file - I explained it in my original post
I fixed the libcudnn version of the library to use the Regards |
trying to avoid confusion
@tfboyd yes 7.5.1 is the TensorRT version we'd like to use but we need to remove the installation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if we need to install the nvinfer-runti-trt-repo.... Then we are done and this is a nice improvement.
site/en/install/gpu.md
Outdated
libcudnn7=7.4.1.5-1+cuda10.0 \ | ||
libcudnn7-dev=7.4.1.5-1+cuda10.0 | ||
libcudnn7=7.6.0.64-1+cuda10.0 \ | ||
libcudnn7-dev=7.6.0.64-1+cuda10.0 | ||
</code> | ||
|
||
# Install TensorRT. Requires that libcudnn7 is installed above. | ||
<code class="devsite-terminal">sudo apt-get update && \ | ||
sudo apt-get install nvinfer-runtime-trt-repo-ubuntu1804-5.0.2-ga-cuda10.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, last item. We need to test if the install of the libnvinfra can be done without needing to install the nvinfer-runti-trt-repo. I suspect Yes given the code below is install a version different than the repo; but I would like that validated. Easy to do if you have a local fresh ubuntu docker or VM. I may get to it but I suspect anyone would be faster than me.
Hey,
Regards PS: I think everything is fixed now – optically and logically .. so lets put it on the site so new users can install TensorRT… and the new versions of libcudnn7 |
libnvinfer5 and libnvinfer-dev dont need that repo or dep file to install just `http://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu1804/x86_64`
|
removed unnecessary repository
ironed out everything – ready to be pushed on the manual website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for TensorRT related changes, thanks!
Please wait for other approvals before merging.
@omen23 Thank you for doing all the hardwork. Testing this stuff takes time, I would know for sure, and I really appreciate it. LGTM from me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, everyone. Appreciate it!
PiperOrigin-RevId: 253061213
fix wrong version numbers - libcudnn is still working with old numbers but libnvinfer5 is not
you can also use
7.6.0.64-1+cuda10.0
forlibcudnn7
but it auto upgraded to7.6.0.64-1+cuda10.1
- so who cares and libnvinfer5 will only install withlibnvinfer5=5.1.5-1+cuda10.0
orlibnvinfer5=5.1.2-1+cuda10.0
if you pass it the correct version number. Same for the development library. Just signed the CLAWould be nice if I knew this earlier (using a Ubuntu / kubuntu 19.04 disco base system with repos for LTS 18.04.2)