Skip to content

Commit

Permalink
Internal change.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 257557065
  • Loading branch information
julienvalentin authored and Copybara-Service committed Jul 11, 2019
1 parent 4df7719 commit 62c4a53
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions tensorflow_graphics/geometry/representation/ray.py
Expand Up @@ -83,7 +83,7 @@ def triangulate(startpoints, endpoints, weights, name=None):

left_hand_side_list = []
right_hand_side_list = []
# TODO: Replace the inefficient for loop and add comments here.
# TODO(b/130892100): Replace the inefficient for loop and add comments here.
for ray_id in range(weights.shape[-1]):
weights_single_ray = weights[..., ray_id]
startpoints_single_ray = startpoints[..., ray_id, :]
Expand Down Expand Up @@ -116,7 +116,7 @@ def triangulate(startpoints, endpoints, weights, name=None):
return points


# TODO: Add batch support for radii and return [A1, ... , 3, 2].
# TODO(b/130893491): Add batch support for radii and return [A1, ... , 3, 2].
def intersection_ray_sphere(sphere_center,
sphere_radius,
ray,
Expand Down
2 changes: 1 addition & 1 deletion tensorflow_graphics/math/interpolation/bspline.py
Expand Up @@ -30,7 +30,7 @@
from tensorflow_graphics.util import shape


# TODO: remove when TF API is
# TODO(b/131510643): remove when TF API is
def _mod(x, y):
return x - tf.cast((x // y) * y, dtype=x.dtype)

Expand Down
Expand Up @@ -568,7 +568,7 @@
"gt = tf.where(tf.greater(intersection_3d[:, :, 2], 0.0), gt, tf.zeros_like(gt))\n",
"gt *= factor\n",
"\n",
"# TODO: gt and sh_integration differ by a factor of pi.\n",
"# TODO(b/124463095): gt and sh_integration differ by a factor of pi.\n",
"sh_integration = np.transpose(sh_integration, (1, 0))\n",
"gt = np.transpose(gt, (1, 0))\n",
"\n",
Expand Down
Expand Up @@ -18,7 +18,7 @@ limitations under the License.
* receive and parse response.
*/

// TODO: this class must be refactored into base DataProvider and
// TODO(b/135959734): this class must be refactored into base DataProvider and
// subclass ArrayBufferDataProvider later.
var vz_mesh;
(function(vz_mesh) {
Expand Down
Expand Up @@ -34,7 +34,7 @@ class MeshViewer extends THREE.EventDispatcher {
this._runColor = runColor;
}

// TODO replace with some thirdparty library call.
// TODO(b/130030314) replace with some thirdparty library call.
/**
* Returns true if the specified value is an object.
* @param {?} val Variable to test.
Expand Down
2 changes: 1 addition & 1 deletion tensorflow_graphics/util/tests/test_case_test.py
Expand Up @@ -53,7 +53,7 @@ def test_assert_tf_lite_convertible_exception_not_raised(self, test_inputs):
@parameterized.parameters(None, (((1.0,),),))
def test_assert_tf_lite_convertible_exception_raised(self, test_inputs):
"""Tests that assert_tf_lite_convertible succeeds with a simple function."""
# TODO: TFLite conversion throws SIGABRT instead of Exception.
# TODO(b/131912561): TFLite conversion throws SIGABRT instead of Exception.
return
# pylint: disable=unreachable
# This code should be able to catch exceptions correctly once TFLite bug
Expand Down

0 comments on commit 62c4a53

Please sign in to comment.