-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stack's nix support #168
Conversation
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Thanks for the patch. Please sign CLA. @grwlf who added nix support in the first place should probably take a look as I don't understand nor use Nix. |
I signed it! |
CLAs look good, thanks! |
Jenkins test this please. |
This works fantastically, thanks |
What is blocking this to be merged? (Apart from the obvious conflict?) @grwlf ? |
I think we just want someone else nix literate to take a look. If you'd like to look over the code and give a thumbs up that should be good enough :) |
This PR is a definite improvement over what's currently in master. So I recommend merging it. |
Thanks! @nmattia do you mind rebasing? (I think you just need to update the version in the tarball URL + its SHA) |
Yep, will do. I should have a few free cycles tomorrow. |
I've:
@jyp can you let me know if this still works for you? I don't have a global stack install, and adding stack to the nix-shell may cause issues there. |
@nmattia Thanks a lot; this is a very useful PR. (I don't have a global stack install either.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an overall improvement, so let's merge it.
This makes use of
stack --nix
instead of providingtools/userchroot
. It provides ashell.nix
that can be used but now the users can build withstack --nix build
. For mestack --nix test
works out of the box. The nix support is disabled by default in thestack.yaml
, hence you do need to pass--nix
to your stack commands.This fixes a few issues I ran into while trying to build:
nix/update
that will update the commit to the header ofrelease-17.09
.AFAICT this removes the need for
buildFHSUserEnv
.Now I need to figure out what that Google CLA is about...