Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorFlow 1.13 support #54

Closed
yongtang opened this issue Jan 14, 2019 · 3 comments · Fixed by #56
Closed

TensorFlow 1.13 support #54

yongtang opened this issue Jan 14, 2019 · 3 comments · Fixed by #56

Comments

@yongtang
Copy link
Member

There are some tf.data API changes between TensorFlow 1.12 and 1.13 which breaks the build of tensorflow-io. This issue is created to track the the effort needed to provide TensorFlow 1.13 support for tensorflow-io.

@yongtang yongtang pinned this issue Jan 14, 2019
@yongtang
Copy link
Member Author

We will need to carry tensorflow/tensorflow#24899 and tensorflow/tensorflow#24903 once we switch from TensorFlow 1.12 to TensorFlow 1.13.

@yongtang
Copy link
Member Author

yongtang commented Feb 7, 2019

Added the comment here as well:

I am continuing to play with tf 1.12.0 vs. 1.13.0. Noticed that the C++ binaries build against 1.12.0 will not work with 1.13.0, as the following has changed:

# 1.12.0:
tensorflow::kernel_factory::OpKernelRegistrar::InitInternal( \
  tensorflow::KernelDef const*, absl::string_view, \
  tensorflow::OpKernel* (*)(tensorflow::OpKernelConstruction*))
# 1.13.0
tensorflow::kernel_factory::OpKernelRegistrar::InitInternal( \
  tensorflow::KernelDef const*, absl::string_view, \
  std::unique_ptr<tensorflow::kernel_factory::OpKernelFactory, \
  std::default_delete<tensorflow::kernel_factory::OpKernelFactory> >)

That means we do have to release a binary against 1.13.0 even if we use tensorflow's public endpoint Python API.

@yongtang
Copy link
Member Author

/cc @jsimsa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant