Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back S3_VERIFY_SSL environment variable #1790

Merged
merged 1 commit into from
May 8, 2023

Conversation

fsonntag
Copy link
Contributor

#1343 removed the environment variable S3_VERIFY_SSL.

Even though it's discouraged to disable SSL verification, it is still useful to do so in development environments. So it would be great to bring this back.

@google-cla
Copy link

google-cla bot commented Apr 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fsonntag
Copy link
Contributor Author

@yongtang Can you take a look at this? Would be great to have this functionality back :)

@yongtang
Copy link
Member

@fsonntag thanks for the contribution - can you sign the CLA as was shown ?

@fsonntag
Copy link
Contributor Author

@fsonntag thanks for the contribution - can you sign the CLA as was shown ?

@yongtang I'm sorry, but I already signed it and the CI seems to show the CLA check as passing. Or do I misunderstand it?

@fsonntag
Copy link
Contributor Author

fsonntag commented May 8, 2023

@yongtang Is it possible to push this through? :) I think the failed CI is not related to this change!

@yongtang yongtang merged commit 1be45af into tensorflow:master May 8, 2023
28 of 32 checks passed
@yatbear
Copy link
Member

yatbear commented May 15, 2023

Hi tensorflow-io team,

Since this fix isn't incorporated in the latest pip version nor the nightly (last candidate was from March). When will the next pip release happen? Are there any plans to fix the nightly soon? Thanks!

@fsonntag
Copy link
Contributor Author

@yongtang Yep, would be great if we can get a nightly with this sooooon. I realize the issue is the broken CI pipeline.

I sent an MR fixing the Linux one here: #1797

But I don't really know how to fix the Windows one... is it maybe possible to manually publish a nightly release? :)

@yingding
Copy link

I need this on my Kubeflow on-prem production environment. I got some issue to use tensorflow-io with an on-prem minio s3 bucket. Please bring back the S3_VERIFY_SSL env setting asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants