New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DICOM doc update #625
DICOM doc update #625
Conversation
This PR is a follow up for 624, which was merged prematurely (sorry). This PR: 1) Popoulate the python docstring of `tfio.image.decode_dicom_image` and `tfio.image.decode_dicom_data` and carry the content from original README.md. 2) Added linking to the tutorial from the python docstring, as was suggested in the review. 3) The tensorflow_io/dicom had been move to tfio.image.decode_dicom_image and tfio.image.decode_dicom_data. As such the REAME.md in tensorflow_io/dicom is not visible anymore. This PR uses python docstring to provides all the necessarily information, including additional links and citations. Also a couple of small typos and missing `,` have been fixed. This PR is a following up of 624. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
@MarkDaoust Sorry for merging too soon in PR #624. This PR tries to address the remaining comments. Please take a look. Also, please let me know if any additional changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yong.
These changes look good.
One question.
Would it make sense to link to the notebook from the old README.md location: tensorflow_io/dicom/README.md
?
I thought that directory existed because of the tfio.dicom
submodule.... but now that directory doesn't exist? I guess I'm a little confused about the project organization.
Thanks @MarkDaoust. We changed the layout to create different namespaces to maintain some level of compatibility:
Also, we tries to group several module/directories into one if possible, as we had too many subdirectories. For example, Therefore, we place To take
We also use the following way to expose APIs:
Let me know if there are any questions. |
Thank you for the detailed explanation Yong. These all sound like helpful changes. We'll just need to be sure to verify the generated api-reference docs that we generate for your next release, to be sure that the generator properly handles the new organization. |
* This avoids tfio reinstalling tf before applying tf_version. * `tfio.image` doesn't exist in the current stable tfio.
Thanks @MarkDaoust for the help 👍 , much appreciated! |
* DICOM doc update This PR is a follow up for 624, which was merged prematurely (sorry). This PR: 1) Popoulate the python docstring of `tfio.image.decode_dicom_image` and `tfio.image.decode_dicom_data` and carry the content from original README.md. 2) Added linking to the tutorial from the python docstring, as was suggested in the review. 3) The tensorflow_io/dicom had been move to tfio.image.decode_dicom_image and tfio.image.decode_dicom_data. As such the REAME.md in tensorflow_io/dicom is not visible anymore. This PR uses python docstring to provides all the necessarily information, including additional links and citations. Also a couple of small typos and missing `,` have been fixed. This PR is a following up of 624. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Move %tensorflow_version, use tfio-nightly * This avoids tfio reinstalling tf before applying tf_version. * `tfio.image` doesn't exist in the current stable tfio.
This PR is a follow up for #624, which was merged prematurely (sorry).
This PR:
tfio.image.decode_dicom_image
and
tfio.image.decode_dicom_data
and carry the content from originalREADME.md.
in the review.
and tfio.image.decode_dicom_data. As such the REAME.md in tensorflow_io/dicom
is not visible anymore. This PR uses python docstring to provides all
the necessarily information, including additional links and citations.
Also a couple of small typos and missing
,
have been fixed.This PR is a following up of #624.
Signed-off-by: Yong Tang yong.tang.github@outlook.com