Add option to initialize decode_avro resource, so that compiled avro schema could be reused #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…schema could be reused This PR add a decode_avro_init which returns a resource handle with compiled avro schema. The resource handle could then be passed to decode_avro multiple times, thus avoiding recompile of avro schema. Note decode_avro could accept both a string (schema) or a resource handle. If a string is passed, the recompile of schema will be done in place within the kernel ops of decode_avro. This PR is backward-compatible. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
/cc @kaiwaehner @sbaier1, this PR is also related to the optimization for KafkaDataset (issue #611). |
terrytangyuan
approved these changes
Dec 4, 2019
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
…schema could be reused (tensorflow#628) * Convert decode_avro's schema as tensor (vs. attr) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add option to initialize decode_avro resource, so that compiled avro schema could be reused This PR add a decode_avro_init which returns a resource handle with compiled avro schema. The resource handle could then be passed to decode_avro multiple times, thus avoiding recompile of avro schema. Note decode_avro could accept both a string (schema) or a resource handle. If a string is passed, the recompile of schema will be done in place within the kernel ops of decode_avro. This PR is backward-compatible. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a decode_avro_init which returns a resource handle with compiled avro schema.
The resource handle could then be passed to decode_avro multiple times, thus avoiding recompile of avro schema.
Note decode_avro could accept both a string (schema) or a resource handle. If a string is passed, the recompile of schema will be done in place within the kernel ops of decode_avro. This PR is backward-compatible.
This PR is part of the effort for issue #611.
Signed-off-by: Yong Tang yong.tang.github@outlook.com