Allows check/lint individual files with bazel run //tools/lint:check -- clang -- file.cc
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -- clang -- file.cc` This PR update out lint tool so that it is possible to run: `bazel run //tools/lint:check -- clang -- file.cc` to check specific file.cc, and run: `bazel run //tools/lint:lint -- clang -- file.cc` to reformat specific file.cc. In addition, this PR also adds support for black so that `bazel run //tools/lint:lint -- black -- tensorflow_io/python/core/ops/version_ops.py` (for lint) `bazel run //tools/lint:check -- black -- tensorflow_io/python/core/ops/version_ops.py` (for check) could be used similiarly. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
/cc @terrytangyuan I only used black for one file Once your PR #812 is complete we can enable black for CI. Also, you can run to check all, and run to format all. (That will trigger lots of errors through so we may need to do it in piecemeal.) |
|
Great! This will help a lot :) |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
… -- clang -- file.cc` (tensorflow#837) * Allows check/lint individual files with `bazel run //tools/lint:check -- clang -- file.cc` This PR update out lint tool so that it is possible to run: `bazel run //tools/lint:check -- clang -- file.cc` to check specific file.cc, and run: `bazel run //tools/lint:lint -- clang -- file.cc` to reformat specific file.cc. In addition, this PR also adds support for black so that `bazel run //tools/lint:lint -- black -- tensorflow_io/python/core/ops/version_ops.py` (for lint) `bazel run //tools/lint:check -- black -- tensorflow_io/python/core/ops/version_ops.py` (for check) could be used similiarly. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Format tensorflow_io/core/python/ops/version_ops.py with black. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix setup.py Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update out lint tool so that it is possible to run:
bazel run //tools/lint:check -- clang -- file.ccto check specific file.cc, and run:
bazel run //tools/lint:lint -- clang -- file.ccto reformat specific file.cc.
In addition, this PR also adds support for black so that
bazel run //tools/lint:lint -- black -- tensorflow_io/python/core/ops/version_ops.py(for lint)bazel run //tools/lint:check -- black -- tensorflow_io/python/core/ops/version_ops.py(for check)could be used similiarly.
Signed-off-by: Yong Tang yong.tang.github@outlook.com