Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easy to use configuration scripts #235

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rnett
Copy link
Contributor

@rnett rnett commented Mar 9, 2021

Adds bazel configuration scripts that download the tensorflow binary and call its configure scripts. The bazel info output_base use is because in some cases (such as switching OSs), the symlinks become corrupted and bazel doesn't generate new ones. The .bazelversion file is for bazelisk, since tensorflow doesn't support 4.0.0 yet.

Fixes #206

Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
karllessard
karllessard previously approved these changes Mar 9, 2021
Copy link
Collaborator

@karllessard karllessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left two small comments there but it's approved for merging

tensorflow-core/tensorflow-core-api/build.sh Outdated Show resolved Hide resolved
tensorflow-core/tensorflow-core-api/configure Outdated Show resolved Hide resolved
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
@rnett
Copy link
Contributor Author

rnett commented Mar 9, 2021

Your approval got removed when I pushed changes, and I don't think I can override the CI.

Signed-off-by: Ryan Nett <JNett96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README should include an example of a build command with explicit component paths
3 participants