Skip to content

Commit

Permalink
Don't add tf summary when calling AddEvalMetric.
Browse files Browse the repository at this point in the history
Eval metric summaries are added inside trainer.py.

As a result, eval metrics are no longer reported by 'control' job, but that actually removes some clutter instead because control should be identical to train.

PiperOrigin-RevId: 213532190
  • Loading branch information
jonathanasdf committed Sep 20, 2018
1 parent 2e06c34 commit 5d1e58f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lingvo/core/base_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,6 @@ def AddEvalMetric(self, name, value, weight):
"""
if name in self._eval_metrics:
raise ValueError('Metric %s has already been defined.' % name)
summary_utils.scalar(self.params, name, value)
self._eval_metrics[name] = (value, weight)

@property
Expand Down

0 comments on commit 5d1e58f

Please sign in to comment.