This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
small io improvements #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def _file_chunk_iterator(file_handle): | ||
| reader = partial(file_handle.read, DEFAULT_BUFFER_SIZE) | ||
| reader = partial(file_handle.read, _READ_BUFFER_SIZE) | ||
| file_iterator = iter(reader, bytes()) | ||
| # TODO: once dropping Python <3.3 compat, update to `yield from ...` |
There was a problem hiding this comment.
Can you in this process also fix the TODO? We're on modern Python these days. Thanks!
There was a problem hiding this comment.
I don't think we're dropping Python 3.3 explicitly though, so I'd like to defer this for now. I do agree that in practice our team is on modern Python these days.
lucid/misc/io/scoping.py
Outdated
| @@ -20,10 +20,13 @@ def set_io_scopes(scopes): | |||
|
|
|||
|
|
|||
| @contextmanager | |||
| def io_scope(path): | |||
| def io_scope(path, absolute=False): | |||
There was a problem hiding this comment.
as discussed oob: let's use replace_current_scopes or similar as the kwarg. :-)
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small improvements to make io scopes a bit more flexible and improve inference of data formats by allowing deeper recursion.