Skip to content

Commit

Permalink
do regular virtualenv install because --user breaks Travis, also disa…
Browse files Browse the repository at this point in the history
…ble flaky pylint check.

PiperOrigin-RevId: 259402104
  • Loading branch information
cghawthorne authored and copybara-github committed Jul 22, 2019
1 parent dfa9344 commit 09b0eaa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ci-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ sudo apt-get -y install build-essential libasound2-dev libjack-dev libav-tools s
# Ensure python 3.7 used, set up an isolated virtualenv.
PY3_PATH="$(which python3.7)"
${PY3_PATH} -m pip --version
${PY3_PATH} -m pip install --user virtualenv
${PY3_PATH} -m pip install virtualenv
${PY3_PATH} -m virtualenv /tmp/magenta-env --python="${PY3_PATH}"
source /tmp/magenta-env/bin/activate
echo $(which python)
Expand Down
3 changes: 3 additions & 0 deletions magenta/pipelines/drum_pipelines.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,14 @@ def __init__(self, min_bars=7, max_steps=512, gap_bars=1.0, name=None):

def transform(self, quantized_sequence):
try:
# pylint has a false positive error on this method call for some reason.
# pylint:disable=redundant-keyword-arg
drum_tracks, stats = extract_drum_tracks(
quantized_sequence,
min_bars=self._min_bars,
max_steps_truncate=self._max_steps,
gap_bars=self._gap_bars)
# pylint:enable=redundant-keyword-arg
except events_lib.NonIntegerStepsPerBarError as detail:
tf.logging.warning('Skipped sequence: %s', detail)
drum_tracks = []
Expand Down

0 comments on commit 09b0eaa

Please sign in to comment.