This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
minor spelling tweaks in markdown files under g3doc directory #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker-eph
reviewed
Sep 25, 2019
g3doc/ConversionToLLVMDialect.md
Outdated
| @@ -88,7 +88,7 @@ type will be a wrapped LLVM IR structure type where each element of the | |||
| structure corresponds to one of the results of the original function, converted | |||
| using these rules. In high-order functions, function-typed arguments and results | |||
| are converted to a wrapped LLVM IR function pointer type (since LLVM IR does not | |||
| allow passing functions to functions without indirection) with the pointee type | |||
| allow passing functions to functions without indirection) with the pointer type | |||
There was a problem hiding this comment.
I think pointee was intentional here.
g3doc/OpDefinitions.md
Outdated
| @@ -18,7 +18,7 @@ best practices. They are rendered as quoted bullet points. | |||
| ## Motivation | |||
|
|
|||
| MLIR allows pluggable dialects, and dialects contain, among others, a list of | |||
| operations. This open and extensible ecosystem leads to the "stringly" type IR | |||
| operations. This open and extensible ecosystem leads to the "strongly" type IR | |||
There was a problem hiding this comment.
stringly was intended here.
There was a problem hiding this comment.
Thank you for pointing out. I should have read the next line carefully.
|
Thanks for the contributions! |
joker-eph
approved these changes
Sep 25, 2019
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Dec 24, 2019
Closes tensorflow/mlir#145 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#145 from kiszk:spelling_tweaks_g3doc ae9140aab5b797441e880d43e557903585815e40 PiperOrigin-RevId: 271173907
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.