Drop obsolete code from std to llvm memref lowering #179

bondhugula · 2019-10-10T16:16:29Z

dropping what looks like outdated code post some of the previous
updates

Signed-off-by: Uday Bondhugula uday@polymagelabs.com

- dropping what looks like outdated code post some of the previous updates Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>

joker-eph · 2019-10-11T00:02:36Z

@bondhugula can you fix this? Thanks!

lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:608:10: error: unused variable 'numOperands' [-Werror,-Wunused-variable]
    auto numOperands = allocOp.getNumOperands();
         ^
1 error generated.

bondhugula · 2019-10-11T02:49:36Z

@bondhugula can you fix this? Thanks!

lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:608:10: error: unused variable 'numOperands' [-Werror,-Wunused-variable]
    auto numOperands = allocOp.getNumOperands();
         ^
1 error generated.

Yes, I actually fixed that while the build check was running. It should be fine now.

nicolasvasilache

Thanks @bondhugula !

- dropping what looks like outdated code post some of the previous updates Signed-off-by: Uday Bondhugula <uday@polymagelabs.com> Closes #179 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#179 from bondhugula:llfix 2a72ea441fe1b3924802273ffbe9870afeb90f91 PiperOrigin-RevId: 274158273

- dropping what looks like outdated code post some of the previous updates Signed-off-by: Uday Bondhugula <uday@polymagelabs.com> Closes tensorflow/mlir#179 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#179 from bondhugula:llfix 2a72ea441fe1b3924802273ffbe9870afeb90f91 PiperOrigin-RevId: 274158273

googlebot added the cla: yes label Oct 10, 2019

joker-eph requested review from nicolasvasilache and ftynse October 10, 2019 16:17

ftynse approved these changes Oct 10, 2019

View reviewed changes

ftynse added the kokoro:run label Oct 10, 2019

kokoro-team removed the kokoro:run label Oct 10, 2019

ftynse added the ready to pull label Oct 10, 2019

Drop obsolete code from std to llvm memref lowering

2a72ea4

- dropping what looks like outdated code post some of the previous updates Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>

bondhugula force-pushed the llfix branch from 897b3ad to 2a72ea4 Compare October 10, 2019 21:15

joker-eph added the kokoro:run label Oct 11, 2019

kokoro-team removed the kokoro:run label Oct 11, 2019

joker-eph added the kokoro:run label Oct 11, 2019

nicolasvasilache approved these changes Oct 11, 2019

View reviewed changes

mlir-copybara-bot closed this in b53ae93 Oct 11, 2019

bondhugula deleted the llfix branch December 9, 2019 03:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop obsolete code from std to llvm memref lowering #179

Drop obsolete code from std to llvm memref lowering #179

bondhugula commented Oct 10, 2019

joker-eph commented Oct 11, 2019 •

edited

bondhugula commented Oct 11, 2019

nicolasvasilache left a comment

Drop obsolete code from std to llvm memref lowering #179

Drop obsolete code from std to llvm memref lowering #179

Conversation

bondhugula commented Oct 10, 2019

joker-eph commented Oct 11, 2019 • edited

bondhugula commented Oct 11, 2019

nicolasvasilache left a comment

Choose a reason for hiding this comment

joker-eph commented Oct 11, 2019 •

edited