This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
Added Tanh lowering from standard to LLVM. #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pifon2a
suggested changes
Dec 12, 2019
joker-eph
reviewed
Dec 12, 2019
pifon2a
approved these changes
Dec 12, 2019
joker-eph
reviewed
Dec 12, 2019
| using LLVMFuncOpT = LLVM::LLVMFuncOp; | ||
| using LLVMTypeT = LLVM::LLVMType; | ||
|
|
||
| assert(operands.size() == 1 && "tanh takes one operand"); |
There was a problem hiding this comment.
This should be handled by the verifier, we don't duplicate invariant checks in general.
(Alex is fixing it on integration, just saying FYI for future patches)
tensorflow-copybara
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Dec 12, 2019
…hf`. Closes #312 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#312 from dfki-ehna:tanh 9e89b072ff91ff390ad739501745114feb3ac856 PiperOrigin-RevId: 285205674 Change-Id: I826e66194ad5827c24c3631c8f9817db6e9b4ff6
dfki-jugr
pushed a commit
to dfki-jugr/mlir
that referenced
this pull request
Dec 13, 2019
…hf`. Closes tensorflow#312 COPYBARA_INTEGRATE_REVIEW=tensorflow#312 from dfki-ehna:tanh 9e89b07 PiperOrigin-RevId: 285205674
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Dec 24, 2019
…hf`. Closes tensorflow/mlir#312 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#312 from dfki-ehna:tanh 9e89b072ff91ff390ad739501745114feb3ac856 PiperOrigin-RevId: 285205674
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.