This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
[spirv] Add lowering from std dialect for fdiv, frem, fsub. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pifon2a
approved these changes
Dec 11, 2019
MaheshRavishankar
approved these changes
Dec 11, 2019
tensorflow-copybara
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Dec 11, 2019
Closes #313 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#313 from denis0x0D:sandbox/lowering_std_farith 41715070a74d13bfa9401957478978c1bb8006c0 PiperOrigin-RevId: 285023586 Change-Id: Iec72064c734c016855e491489cb01440f2eaf433
dfki-jugr
pushed a commit
to dfki-jugr/mlir
that referenced
this pull request
Dec 13, 2019
Closes tensorflow#313 COPYBARA_INTEGRATE_REVIEW=tensorflow#313 from denis0x0D:sandbox/lowering_std_farith 4171507 PiperOrigin-RevId: 285023586
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Dec 24, 2019
Closes tensorflow/mlir#313 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#313 from denis0x0D:sandbox/lowering_std_farith 41715070a74d13bfa9401957478978c1bb8006c0 PiperOrigin-RevId: 285023586
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@antiagainst @MaheshRavishankar I've noticed some missing patterns for lowering arithmetic operations from std dialect. Can you please take a look?