Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pruning wildcard imports for determining what symbols are public APIs, to mirror quantization. #427

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jun 16, 2020

Remove pruning wildcard imports for determining what symbols are public APIs, to mirror quantization.

This prevents accidentally exposing private symbols as public APIs.

Validated that build_docs.py produces API docs with expected symbols, even without private_map blacklist.

@googlebot googlebot added the cla: yes PR contributor has signed CLA label Jun 16, 2020
@copybara-service copybara-service bot changed the title Remove pruning wildcard imports for determining what symbols are public APIs, to mirror Remove pruning wildcard imports for determining what symbols are public APIs, to mirror quantization. Jun 18, 2020
…ic APIs, to mirror quantization.

This prevents accidentally exposing private symbols as public APIs.

Validated that build_docs.py produces API docs with expected symbols, even without `private_map` blacklist.

PiperOrigin-RevId: 317025882
@copybara-service copybara-service bot merged commit cb52f5d into master Jun 18, 2020
@copybara-service copybara-service bot deleted the test_316606374 branch June 18, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR contributor has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants