Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

num_replicas -> num_replicas_in_sync #5752

Merged
merged 1 commit into from Nov 14, 2018
Merged

num_replicas -> num_replicas_in_sync #5752

merged 1 commit into from Nov 14, 2018

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Nov 14, 2018

num_replicas is being replaced by num_replicas_in_sync and something that returns the number of steps running concurrently.

`num_replicas` is being replaced by `num_replicas_in_sync` and something that returns the number of steps running concurrently.
@josh11b josh11b requested review from karmel and a team as code owners November 14, 2018 06:12
@guptapriya guptapriya self-requested a review November 14, 2018 06:25
@robieta
Copy link
Contributor

robieta commented Nov 14, 2018

Can you also look into the AttributeError: 'OneDeviceStrategy' object has no attribute 'call_for_each_tower' error?

@josh11b
Copy link
Contributor Author

josh11b commented Nov 14, 2018

Can you also look into the AttributeError: 'OneDeviceStrategy' object has no attribute 'call_for_each_tower' error?

That is from using an outdated version of tensorflow_estimator/python/estimator/estimator.py and is should be unrelated to this PR (I suspect that is failing without this PR). @case540 may be able to help.

@robieta robieta merged commit 4d4eb85 into master Nov 14, 2018
@tfboyd tfboyd deleted the josh11b-patch-4 branch February 7, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants