Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility for newer tensorflow and python3 #6587

Merged
merged 2 commits into from Apr 17, 2019

Conversation

@NatLee
Copy link
Contributor

commented Apr 16, 2019

  1. In python3, dict.iteritems() is gone, change it to dict.items(). And it also doesn't treat zip object as a list, so change zip to list type.
  2. Add encoding flag with open function to make it more compatible for Windows/Linux system.
  3. For newer tensorflow, it expected int64 without giving a dtype parameter to embedding layer. We give it float32 to solve it.

@NatLee NatLee requested review from a-dai and rsepassi as code owners Apr 16, 2019

@googlebot googlebot added the cla: yes label Apr 16, 2019

@a-dai
a-dai approved these changes Apr 17, 2019

@a-dai a-dai merged commit cbd8136 into tensorflow:master Apr 17, 2019

1 check passed

cla/google All necessary CLAs are signed
wlongxiang added a commit to wlongxiang/models that referenced this pull request Apr 24, 2019
Fix compatibility for newer tensorflow and python3 (tensorflow#6587)
1. In python3, dict.iteritems() is gone, change it to dict.items(). And it also doesn't treat zip object as a list, so change zip to list type.
2. Add encoding flag with open function to make it more compatible for Windows/Linux system.
3. For newer tensorflow, it expected int64 without giving a dtype parameter to embedding layer. We give it float32 to solve it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.