Fix BERT EmbeddingPostprocessor #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vooblin
requested review from
guptapriya,
rachellj218 and
saberkun
as code owners
|
|
Gather is supported in tflite |
|
I see. That's great. |
saberkun
approved these changes
Oct 23, 2019
saberkun
added
the
ready to pull
tf-models-copybara-bot
pushed a commit
that referenced
this pull request
Oct 23, 2019
PiperOrigin-RevId: 276182092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change one_hot+matmul on gather. It's important for conversion to tflite because one_hot+matmul seriously change model predictions after conversion in tflite format. Gather does the same operations and doesn't have the same effect.
It is related to problem in tflite. Issue: tensorflow/tensorflow#33613.
My fix allow to convert model to tflite before this problem will be solved