Recommend 'tensorflow-probability[tf]' extra on tf-keras import failure #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In addition to recommending users install TensorFlow dependencies piecemeal, also recommend using the 'tf' extra to install all required dependencies to use tensorflow-probability with tensorflow. * Split this off from the rest of the error message as it is already too long.
matthewfeickert
force-pushed
the
fix/suggest-using-extra-in-error-message
branch
from
b3a621d
to
4b480b7
Compare
|
Note the $ pylint -j2 --rcfile=testing/pylintrc tensorflow_probability/python/__init__.py
pylint: Command line or configuration file:1: UserWarning: 'StandardError' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.StandardError' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
pylint: Command line or configuration file:1: UserWarning: 'Exception' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.Exception' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
pylint: Command line or configuration file:1: UserWarning: 'BaseException' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.BaseException' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
************* Module tensorflow_probability.python
W4901: 49 _validate_tf_environment: Deprecated module 'distutils.version' [deprecated-module]
-----------------------------------
Your code has been rated at 9.80/10
|
|
thanks for being on top of this, @matthewfeickert ! |
|
Thank you for the fast review, @ColCarroll! Also thanks to you and the rest of the team for |
|
it was all @jburnim on getting the code in and merged efficiently. i'm just the bearer of gratitude 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this amends 988f023 tagging @jburnim for review.