[fix] embedding variable is_initialized not executed in graph mode #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqsun8819
changed the title
in graph mode, report_uninitialized_variables use state_ops.is_variable_initialized to compose is_initialized_op, for ResourceVariable, this method will call BsaeResourceVariable.is_initialized method to insert this op into graph. EmbeddingVariable should override this method so that ev_is_initailed_op can be composed into report_uninitialized_variables.
qqsun8819
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In graph mode, report_uninitialized_variables use state_ops.is_variable_initialized to compose is_initialized_op, for ResourceVariable, this method will call BsaeResourceVariable.is_initialized method to insert this op into graph.
EmbeddingVariable should override this method so that ev_is_initailed_op can be composed into report_uninitialized_variables.