Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: incompatible jobs with explicit placement. #145

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Fix bug: incompatible jobs with explicit placement. #145

merged 2 commits into from
Aug 30, 2021

Conversation

Lifann
Copy link
Member

@Lifann Lifann commented Aug 26, 2021

Description

Brief Description of the PR: In graph mode, when the device context is explicitly specified by device or replica_device_setter, the session may raise incompatible error if the devices cannot be merged. This PR fixed the case.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

@Lifann Lifann requested a review from rhdong as a code owner August 26, 2021 14:01
@tensorflow tensorflow deleted a comment from google-cla bot Aug 26, 2021
@rhdong
Copy link
Member

rhdong commented Aug 30, 2021

LGTM

@rhdong rhdong merged commit f2d90da into tensorflow:master Aug 30, 2021
@Lifann Lifann deleted the Lifann/fix-explicit-colocation-error branch October 15, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants