Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]Github auto merge hide the email address, revert and push the right address #163

Merged
merged 2 commits into from
Oct 9, 2021

Conversation

MoFHeka
Copy link
Contributor

@MoFHeka MoFHeka commented Oct 9, 2021

Description

Github auto merge may hide the author email address with a anonymous email. Revert last time commit and push the right address.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

…g file to prevent unconditional setting. (tensorflow#159)"

This reverts commit 43b12d3.
…o prevent unconditional setting. (tensorflow#159)

* More type and value check for config file and more reasonable exception catching mechanisms

Simplefy reading json and testing Redis service cluster_enabled and Redis connection parameters code by using macro and father class function

Feed all the exception catching mechanisms into tensorFlow's OP_REQUIRES mechanism and Add more CI about config file mistakes.

* Added a parameter redis_config_abs_dir_env in OP attribute which is the name of the environment variable that stores the path of the Redis configuration file to be read by the specified model for the operation of one machine and multiple models.

* Add redis_read_access_slave in config file to set if all reading access in Redis backend through SLAVE service in redis. In most infer mode sitiuation it could be set true.

Fix bug that's multi-thread throwing exception unable to be catched.

* fix delocate version to 0.9.1. delocate 0.10.0 makes delocate-wheel fail in MacOS

* Many functions were refactored(rebucket) and more bugs were fixed

modify compute_capabilities function in cuda_configure.bzl in case someone sets the environment variable to 11.x
@rhdong
Copy link
Member

rhdong commented Oct 9, 2021

LGTM

@rhdong rhdong merged commit c42b777 into tensorflow:master Oct 9, 2021
MoFHeka added a commit to MoFHeka/recommenders-addons that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants