Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix]I forget to modify RestoreFromDisk and HscanGetKeysValsInBucket in cluster mode code #166

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[hotfix]I forget to modify RestoreFromDisk and HscanGetKeysValsInBucket in cluster mode code #166

merged 1 commit into from
Oct 14, 2021

Conversation

MoFHeka
Copy link
Contributor

@MoFHeka MoFHeka commented Oct 12, 2021 •
edited

Description

Hotfix, I forget to modify RestoreFromDisk and HscanGetKeysValsInBucket in cluster mode code. To fix can not dump embeddings to variable tensors when using Redis cluster mode.

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

old redis CI test but connecting to the Redis cluster

@MoFHeka MoFHeka requested a review from rhdong as a code owner October 12, 2021 15:21
@MoFHeka MoFHeka force-pushed the redis-dev branch 3 times, most recently from 00d2436 to b84d4f7 Compare October 13, 2021 16:13
rhdong
rhdong approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 260db70 into tensorflow:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MoFHeka @rhdong