Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]Fix misprocessing of "CLUSTER NODES" return #185

Merged
merged 1 commit into from
Nov 18, 2021
Merged

[fix]Fix misprocessing of "CLUSTER NODES" return #185

merged 1 commit into from
Nov 18, 2021

Conversation

MoFHeka
Copy link
Contributor

@MoFHeka MoFHeka commented Nov 11, 2021 •
edited

Description

Fixed a serious bug where the "myself,master" field in the node information returned by the "CLUSTER NODES" command was not being processed correctly.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@MoFHeka MoFHeka requested a review from rhdong as a code owner November 11, 2021 05:51
@MoFHeka MoFHeka changed the title Fix misprocessing of "CLUSTER NODES" return [fix]Fix misprocessing of "CLUSTER NODES" return Nov 11, 2021
rhdong
rhdong approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 10b365f into tensorflow:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MoFHeka @rhdong