Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] embedding variable graph mode example #189

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

Nov11
Copy link
Contributor

@Nov11 Nov11 commented Nov 23, 2021

Description

Brief Description of the PR:
fix embedding variable graph mode example in jupyter notebook under docs/tutorial

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

rerun the notebook and it shows output as expected

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Nov11 Nov11 changed the title fix embedding variable graph mode example [fix] embedding variable graph mode example Nov 23, 2021
@rhdong
Copy link
Member

rhdong commented Dec 2, 2021

Hi @liutongxuan @qqsun8819 ,please help review this PR, thanks!

qqsun8819
qqsun8819 previously approved these changes Dec 2, 2021
liutongxuan
liutongxuan previously approved these changes Dec 2, 2021
@rhdong
Copy link
Member

rhdong commented Dec 7, 2021

Hi @Nov11 , please rebase on origin/master and squash all commits to one, after this, I'll merge it, thank you!

@Nov11
Copy link
Contributor Author

Nov11 commented Dec 14, 2021

Hi @Nov11 , please rebase on origin/master and squash all commits to one, after this, I'll merge it, thank you!

Branch has been rebased on master. Please check this PR again.

@rhdong rhdong merged commit bc39850 into tensorflow:master Dec 29, 2021
@rhdong
Copy link
Member

rhdong commented Dec 29, 2021

Hi @Nov11 , please rebase on origin/master and squash all commits to one, after this, I'll merge it, thank you!

Branch has been rebased on master. Please check this PR again.

Done, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants